Exclude anchor links from URL conversion - #129
Merged
Merged
Conversation
n7studios
requested review from
a team,
ciccio-kit and
noelherrick
and removed request for
a team
September 2, 2026 10:15
n7studios
marked this pull request as ready for review
September 2, 2026 10:15
noelherrick
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes this reported issue by ensuring
convert_relative_to_absolute_urlsdoes not convert anchor links.Testing
KitMethodsTest: Copied tests from the PHP SDK to test landing pages (https://github.com/Kit/ConvertKitSDK-PHP/blob/master/tests/ConvertKitMethodsTest.php)Checklist