Fix build when SDK is installed globally - #1999
Merged
charles-lunarg merged 1 commit intoAug 5, 2026
Merged
Conversation
Because of clang always adding /usr/local/include and CMake using -isystem by default in 3.25+, builds on MacOS could use system installed headers by mistake. Because this repo has code generated against a specific version of the Vulkan Headers, if the system installed headers are older (which is usually the case for developers of this repo) then the build fails. Fix it by marking the Vulkan::Headers target as not a system target.
|
CI Vulkan-Loader build queued with queue ID 65375. |
|
CI Vulkan-Loader build queued with queue ID 65392. |
|
CI Vulkan-Loader build # 3679 running. |
|
CI Vulkan-Loader build # 3679 passed. |
jpr42
reviewed
Aug 5, 2026
| endif() | ||
|
|
||
| if (CMAKE_C_COMPILER_ID STREQUAL AppleClang AND TARGET Vulkan::Headers AND CMAKE_VERSION VERSION_GREATER_EQUAL 3.25) | ||
| set_target_properties(Vulkan::Headers PROPERTIES SYSTEM OFF) |
Contributor
There was a problem hiding this comment.
This deserves to be highly commented if you decide to merge this in. It's very non-obvious.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of clang always adding /usr/local/include and CMake using -isystem by default in 3.25+, builds on MacOS could use system installed headers by mistake. Because this repo has code generated against a specific version of the Vulkan Headers, if the system installed headers are older (which is usually the case for developers of this repo) then the build fails.
Fix it by marking the Vulkan::Headers target as not a system target.