Skip to content

Fix "Mix RGB" mode color leaking into single "Backlight" mode color - #494

Open
P4ntomime wants to merge 1 commit into
Keychron:2025q3from
P4ntomime:rgb-cycle-fix
Open

Fix "Mix RGB" mode color leaking into single "Backlight" mode color#494
P4ntomime wants to merge 1 commit into
Keychron:2025q3from
P4ntomime:rgb-cycle-fix

Conversation

@P4ntomime

Copy link
Copy Markdown

Description

Mixed RGB mode sets rgb_matrix_config during rendering but never reverts it to its original state from before / other effects. Proposed in this PR is that both hsv and speed values are saved before rendering mixed rgb mode and re-applied after it.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [X ] My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant