Repository navigation
Fix HIP device UUID handling for integrated GPUs - #427
Merged
benvanwerkhoven merged 1 commit intoNov 16, 2026
Merged
Conversation
Some HIP devices, such as integrated GPUs, report an incomplete UUID buffer. Previously, this would lead to an error when attempting to construct a `uuid.UUID` object from the truncated data. This change modifies the `HipFunctions` backend to check the length of the reported UUID buffer. If the buffer is not the expected full size, the device's UUID environment variable is now set to `None`, gracefully handling devices that do not provide a valid UUID. A new test case has been added to verify this behavior.
kjwierenga
marked this pull request as ready for review
November 16, 2026 14:13
|
benvanwerkhoven
approved these changes
Nov 16, 2026
Collaborator
|
Thanks @kjwierenga! I've tested it on a machine with an AMD GPU (not an integrated one though) and there this works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Some HIP devices, such as integrated GPUs, report an incomplete UUID buffer. Previously, this would lead to an error when attempting to construct a
uuid.UUIDobject from the truncated data.This change modifies the
HipFunctionsbackend to check the length of the reported UUID buffer. If the buffer is not the expected full size, the device's UUID environment variable is now set toNone, gracefully handling devices that do not provide a valid UUID. A new test case has been added to verify this behavior.This fixes #426