fix(ci): report skipped test checks - #142
Merged
Merged
Conversation
GitHub evaluates a job condition before expanding its matrix. A skipped test matrix reports one literal check name and leaves the two required checks absent. Give each Node version its own conditional job. Documentation changes now report both versioned checks as skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub evaluates a job's
ifbefore expanding its matrix. Documentation-only changes reported one skipped check calledTest (Node ${{ matrix.node }}), leaving both required versioned checks absent.This gives each Node version its own conditional job. A documentation-only PR now gets both required checks with skipped conclusions, while code changes still run both test jobs.
Checks
AWS_CONFIG_FILE=/dev/null pnpm check@coderabbitai ignore