Repository navigation
Clear the production audit gate so CI can actually run - #28
Merged
Merged
Conversation
`npm audit --omit=dev` gates the CI job and started failing on advisories published after the last green run (2026-10-17). Because it runs first, it stopped every later step — typecheck, unit tests, package tests, build and the browser suites — before any of them executed. Bump the affected transitive production deps to their patched versions (all within existing semver ranges): @modelcontextprotocol/sdk 1.32.2, @hono/node-server 2.1.5, body-parser 2.4.0, fast-uri 3.1.9, hono 4.13.14, ip-address 10.7.5, qs 6.17.1. Move pdfstudio-mcp from zod 3 to zod 4.6.7, which is the only version outside the advisory range; the MCP SDK 1.32 and zod-to-json-schema 3.25 both declare `^3.25 || ^4` support, and the tool schemas use only the stable surface, so no source changes were needed. `npm audit --omit=dev` now reports 0 vulnerabilities. App (88), core (15), CLI (36) and MCP (19, 3 platform-conditional symlink skips) tests pass; typecheck and build are clean. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
npm audit --omit=devis the first gate inci.yml. Advisories published after the last green run (2026-10-17) made it fail, and because it stops the job, nothing after it had run for weeks — typecheck, unit tests, consistency, package tests, build, and the Playwright browser suites were all skipped. That's why #27 merged with a redverify.Fix
Patched transitive production deps, all within existing semver ranges:
@modelcontextprotocol/sdk@hono/node-serverbody-parserfast-urihonoip-addressqszod(pdfstudio-mcp)zodis the only major. It's required: the advisory coverszod <4.6.6, so no 3.x release is safe. Both the MCP SDK 1.32 (zod: ^3.25 || ^4.0, as dependency and peer) andzod-to-json-schema3.25 (^3.25.28 || ^4) declare zod 4 support, andpackages/mcpuses only the stable surface (z.string/number/boolean/literal/array/union/object,.optional/.describe/.min/.max/.int/.positive). No source changes were needed — verified by typecheck, build and the MCP test suite.Verification
npm audit --omit=dev→ 0 vulnerabilities (exit 0)npm run typecheck→ cleannpm test→ 88/88npm run test:packages→ core 15, CLI 36, MCP 19 (3 skipped are pre-existingit.skipIf(!HAS_SYMLINKS)Windows symlink guards, unchanged)npm run build:packages,npm run build:pages→ cleannode scripts/check-consistency.cjs→ OKNo test was skipped, weakened, or suppressed, and the audit step itself is untouched — the dependency tree is genuinely clean.
Note: this also gives CI a chance to run the browser suites for the first time since October, so it may surface unrelated pre-existing failures. I'll report whatever it finds.