Repository navigation
Reject unsupported exceptions in configured RTU read checks - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configured Modbus RTU reads with
accept_exception: truecould report success for a CRC-correct response carrying an unsupported exception byte, including00orFF. Validate that byte against the existing exception-code contract before applying the acceptance flag, retain the captured frame and explain the rejection. Defined exceptions keep their existing policy and messages; serial settings, read-only requests, transport code and any/all control flow are unchanged.Validation: 421 local tests passed, including 35 new regressions that initially produced 11 failures. Tests exercise the real parser and configured caller with Fake serial, plus CRC, identity, truncation and defined-code controls. A separate zero-third-party replay checked all 4,096 code/function/target/flag combinations, 144 unchanged defined-exception results, 24 ordinary read results and 1,976 unchanged request encodings. Configuration validation and all 23 offline self-checks passed.
Implementation, tests and documentation are AI-assisted. No physical serial device was opened. Broad local coverage is 2,006/3,693 lines (54.32%) and 635/1,456 branches (43.61%); this correction is not hardware or full-service security certification. Independent review and remote CI are checked before integration.