Repository navigation
Fix acceptance reliability, protocol boundaries and CSV retest lineage - #2
Merged
Merged
Conversation
AI-assisted reliability review with 113 added offline regressions. Preserve original task evidence, fail closed on persistent storage failure, validate protocol boundaries and append CSV retest parent identity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance history could be changed by late/conflicting adapter callbacks, and shutdown or storage/startup failures could leave misleading task availability. This AI-assisted review preserves completed evidence, persists retest lineage on the first insert, blocks further operations after terminal persistence failure, and cleans up SQLite bootstrap/worker-start failures.
It also validates HTTP admission/framing before body reads with bounded rejection teardown, applies shared constraints to response alternatives, enforces read-function-specific Modbus limits, and rejects unsupported nested descendants before silently reducing expected-device counts. CSV appends
parent_job_idas column 30; the original 29 columns retain their positions and values. Exactly-29-column external consumers need updating. No new dependency or schema migration is required.Validation:
17b3f4apassed all four push-matrix jobs, but the PR Windows/Python 3.13 job timed out in a preexisting Node helper after 8 seconds (212 other tests passed). Logs are retained. Follow-up584b5d2adds request deadlines, exact 200/200/401 plus JSON-failure assertions, a negative server-token control and completion evidence with a separate subprocess budget. The original delay's cause is unproven; it is not claimed as a production bug.