Repository navigation
Point 693 at Major Hayden's existing person page - #1172
Merged
Merged
Conversation
The scrape derived "major-hayden" from his name, but his page has been "major" since episode 314 — two pages for one person, plus a duplicate avatar (major-hayden.jpg is byte-identical to major.jpg). Drops the duplicate page and image and points 693 at major. The scraper will re-create major-hayden on the next run until "major hayden" maps to major in its usernames_map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Undoes the duplicate person page the scrape created for Major Hayden.
major-hayden.mdduplicatesmajor.md— his page since episode 314, referenced by around 20 episodes across LUP and Coder Radio. The avatar is the same file under a second name:major-hayden.jpgandmajor.jpgare byte-identical.content/people/major-hayden.mdstatic/images/people/major-hayden.jpg0693.md: guestmajor-hayden→majorThis recurs on the next scrape unless
major haydenmaps tomajorin the scraper'susernames_map— same mechanism asjnsgruk→jon-seager.