Repository navigation
Fix broken links in show notes: escape quotes in link titles and replace the dead Fountain referral - #1168
Merged
CGBassPlayer merged 4 commits intoNov 16, 2026
Conversation
…ers as a link (JupiterBroadcasting#426) The title started with a doubled quote, which ended the markdown link title early and left the whole link as literal text. Adds an e2e test for the rendered link.
3 tasks done
CGBassPlayer
marked this pull request as ready for review
November 16, 2026 05:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A link title containing unescaped double quotes ends the markdown title early, so the whole link shows as literal text with the URL pasted inside. This is what broke the "JB is live!" link in Office Hours 12.
content/show/office-hours/0012.md: the link to PR "JB is live!" indicator - on page load, call the script to highlight the #livebutton red if jupiter.tube is live. #378 had""JB is live!" …"as its title. The inner quotes are now escaped."to\"), nothing else on any line.fountain.fm/refer/chrislas-e72160c3c5) returns 404. It is replaced with his profile,https://fountain.fm/chrislas, in the 10 episodes ChrisLAS Fountain referral link -> 404 #448 lists (coder-radio 0472, 0473, 0474, 0475, 0476, 0478, 0480, 0483; office-hours 0008; self-hosted 0079). Only the URL changed on each line.content/show/linux-action-news/0250.md, the episode named in episode link markdown not rendered correctly #221, is one of them.Related issues
Fixes #426.
Fixes #221.
Fixes #448.
Testing
test/e2e/test_episode.py:test_episode_office_hours_12_live_indicator_link: the PR "JB is live!" indicator - on page load, call the script to highlight the #livebutton red if jupiter.tube is live. #378 link renders once as a link, and the page has no literal](.test_link_titles_have_no_unescaped_quotes: scans every show notes file and fails if a link title has a bare quote.test_no_show_notes_use_the_dead_fountain_referral: fails if any show notes file still has the dead referral link.I ran both scan tests on this branch after the Fountain change and they pass. The full e2e run above (1016 passed, 7 xfailed, 0 failures) was before the Fountain commit; CI will run it again.
I checked the rendered Coder Radio 329 page by hand: its Twitter link was literal text before and is a link now. I did not check the guard test against the old content. It uses the same pattern that found the 95 links.
E2E workflow fix
The "Select tests" step in
.github/workflows/e2e.ymlfailed on this PR before running any tests. Its lastgrepexits 1 when every changed file matchesSAFE, andbash -eaborts the step. That happens when a PR changes onlycontent/show/andtest/e2e/test_episode.py, as this one does. Adding|| truefixes it, and the episode tests are still selected for these files. The same commit is in #1167.Notes
The scraper already escapes quotes in link titles (since August 2024), so new episodes are fine; these old episodes were written before that. A re-scrape would replace the full titles with truncated tooltips, because the feed's HTML cuts the title attribute at the first inner quote. ChanceM/show-scraper-2#12 lists these episodes, and the 10 Fountain ones, in
dont_overrideso they are left alone.Screenshots
Local Hugo server. A link with an unescaped quote in its title shows as literal text; now it is a link.
Before, Coder Radio 329
After, Coder Radio 329
Before, Office Hours 12
After, Office Hours 12
Checklist
dont_overridelist merged (Keep hand-merged people pages from being recreated on a rescrape ChanceM/show-scraper-2#12)