Skip to content

Fix broken links in show notes: escape quotes in link titles and replace the dead Fountain referral - #1168

Merged
CGBassPlayer merged 4 commits into
JupiterBroadcasting:developfrom
CGBassPlayer:fix/426-office-hours-12
Nov 16, 2026
Merged

CGBassPlayer merged 4 commits into
JupiterBroadcasting:developfrom
CGBassPlayer:fix/426-office-hours-12

Conversation

@CGBassPlayer

@CGBassPlayer CGBassPlayer commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Description

A link title containing unescaped double quotes ends the markdown title early, so the whole link shows as literal text with the URL pasted inside. This is what broke the "JB is live!" link in Office Hours 12.

Related issues

Fixes #426.

Fixes #221.

Fixes #448.

Testing

test/e2e/test_episode.py:

I ran both scan tests on this branch after the Fountain change and they pass. The full e2e run above (1016 passed, 7 xfailed, 0 failures) was before the Fountain commit; CI will run it again.

I checked the rendered Coder Radio 329 page by hand: its Twitter link was literal text before and is a link now. I did not check the guard test against the old content. It uses the same pattern that found the 95 links.

E2E workflow fix

The "Select tests" step in .github/workflows/e2e.yml failed on this PR before running any tests. Its last grep exits 1 when every changed file matches SAFE, and bash -e aborts the step. That happens when a PR changes only content/show/ and test/e2e/test_episode.py, as this one does. Adding || true fixes it, and the episode tests are still selected for these files. The same commit is in #1167.

Notes

The scraper already escapes quotes in link titles (since August 2024), so new episodes are fine; these old episodes were written before that. A re-scrape would replace the full titles with truncated tooltips, because the feed's HTML cuts the title attribute at the first inner quote. ChanceM/show-scraper-2#12 lists these episodes, and the 10 Fountain ones, in dont_override so they are left alone.

Screenshots

Local Hugo server. A link with an unescaped quote in its title shows as literal text; now it is a link.

Before, Coder Radio 329

1-before-coder-radio-329

After, Coder Radio 329

2-after-coder-radio-329

Before, Office Hours 12

3-before-office-hours-12

After, Office Hours 12

4-after-office-hours-12

Checklist

…ers as a link (JupiterBroadcasting#426)

The title started with a doubled quote, which ended the markdown link title early and left the whole link as literal text. Adds an e2e test for the rendered link.
@CGBassPlayer CGBassPlayer changed the title Escape double quotes in show notes link titles so the links render Fix broken links in show notes: escape quotes in link titles and replace the dead Fountain referral Nov 16, 2026
@CGBassPlayer
CGBassPlayer marked this pull request as ready for review November 16, 2026 05:07
@CGBassPlayer
CGBassPlayer merged commit d4f2a3a into JupiterBroadcasting:develop Nov 16, 2026
1 check passed
@CGBassPlayer
CGBassPlayer deleted the fix/426-office-hours-12 branch November 16, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ChrisLAS Fountain referral link -> 404 Markdown typo in Office Hours 12 episode link markdown not rendered correctly

1 participant