Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #372 +/- ##
==========================================
+ Coverage 96.73% 96.78% +0.05%
==========================================
Files 7 7
Lines 827 840 +13
==========================================
+ Hits 800 813 +13
Misses 27 27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kimikage
force-pushed
the
n0f8_n0f16_to_float16
branch
2 times, most recently
from
October 29, 2026 07:08
5071851 to
bada879
Compare
Collaborator
Author
Benchmarkusing FixedPointNumbers, BenchmarkTools
f16s = zeros(Float16, 1000, 1000);
for f in 2:8
N = Normed{UInt8, f}
ns = rand(N, 1000, 1000);
println(N)
@btime $f16s .= Float16.($ns)
end
for f in 2:16
N = Normed{UInt16, f}
ns = rand(N, 1000, 1000);
println(N)
@btime $f16s .= Float16.($ns)
endJulia v1.13.3julia> versioninfo()
Julia Version 1.13.3
Commit 67ac47b9cd (2026-10-25 15:28 UTC)
Build Info:
Official https://julialang.org release
Platform Info:
OS: Windows (x86_64-w64-mingw32)
CPU: 8 × 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
WORD_SIZE: 64
LLVM: libLLVM-20.1.8 (ORCJIT, tigerlake)
GC: Built with stock GC
Threads: 1 default, 1 interactive, 1 GC (on 8 virtual cores)
|
Collaborator
Author
Julia v1.10.12julia> versioninfo()
Julia Version 1.10.12
Commit d93beab124 (2026-08-15 10:29 UTC)
Build Info:
Official https://julialang.org/ release
Platform Info:
OS: Windows (x86_64-w64-mingw32)
CPU: 8 × 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
WORD_SIZE: 64
LIBM: libopenlibm
LLVM: libLLVM-15.0.7 (ORCJIT, tigerlake)
Threads: 1 default, 0 interactive, 1 GC (on 8 virtual cores)
|
…16}` and `Normed{UInt8}`
kimikage
force-pushed
the
n0f8_n0f16_to_float16
branch
from
October 29, 2026 08:00
bada879 to
714a854
Compare
Float16 conversions from Normed{UInt8} and Normed{UInt16}Float16 conversions from Normed{UInt16} and Normed{UInt8}
kimikage
marked this pull request as ready for review
October 29, 2026 09:02
Float16 conversions from Normed{UInt16} and Normed{UInt8}Float16 conversions from Normed{UInt16} and Normed{UInt8}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the double-rounding issue in
N2f14,N1f15, andN0f16. (Fixes #364)This also make the tests more robust regarding issue #246.
This improves performance for
Normed(UInt16, f)wheref in 8:15. Performance improvements for other types are minor.