Conversation
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Member
|
Looks good to me. I wonder whether we just never got around implementing ForwardDiff for |
Kolaru
reviewed
Sep 8, 2026
Kolaru
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for the PR!
As I mention in comment, to me it looks like that this PR introduce a design that is not guaranteed. And (unfortunately T_T), I think we need to figure that out before we can move forward.
Add integer and rational exponents, including literal integer powers. Assisted-by: Claude Opus 5 <noreply@anthropic.com>
Add differentiation and arithmetic for bare intervals in nested duals. Use thin-zero checks for interval partials in power rules and, when supported by ForwardDiff, its zero-partial checks. Treat real constants and derivative coefficients as exact. Callers who need to track this assumption through `isguaranteed` should use decorated intervals. Assisted-by: Claude Fable 5 (claude-fable-5) <noreply@anthropic.com>
timholy
force-pushed
the
teh/fd-bare
branch
from
September 19, 2026 13:06
9f0c3cb to
f313814
Compare
Contributor
Author
|
I've rebased on current |
This allows FD support without defining operations against inexact quantities Assisted-by: Claude Fable 5.1 <noreply@anthropic.com>
timholy
force-pushed
the
teh/fd-bare
branch
from
September 19, 2026 13:15
f313814 to
f64c50b
Compare
Contributor
Author
|
If you do want to merge this as two commits, LMK and I can squash everything after the first commit together, leaving the first distinct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has two commits; the second depends on the first, but arguably they should be merged without squashing. I can also split into two separate (sequential) PRs if you prefer.
The main goal here is to support differentiation and arithmetic for bare intervals in nested duals. At present I think this is the last performance work I need to make it possible to adopt IA.