Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #732.
Problem
MEGNetConvwrapped its edge and node update layers inStatefulLuxLayer, but returned the original state unchanged. Updates from stateful sublayers such asBatchNormwere therefore lost between calls.Solution
Return the updated states from both the edge update layer (
ϕe) and node update layer (ϕv) after the MEGNet forward pass.Changes Made
MEGNetConvforward method to return both sublayers’ updated states.BatchNorminϕe, including reuse of the returned state.Testing
Test results: The focused runner completed with 227 passes and 2 broken/skipped tests. The full GNNLux CPU runner completed with 183 passes and 2 broken/skipped tests; both exited with code 0. The runs logged sandbox-related Revise path permission errors.
Pkg.test()was blocked by a registry archive permission error, so I ran the package test runner directly.