fix: avoid type var in Mesh constructor to enable JuliaC trimming - #282
Merged
Conversation
asinghvi17
reviewed
Aug 9, 2026
The type variable in the `Mesh` constructor was preventing JuliaC from being able to statically resolve types for trimming. Only use a type variable when the deprecated `normals` attribute is provided. Also fix the attribute name substitution! The previous logic had a bug in it that resulted in the code not actually substituting `normals` for `normal`.
Contributor
Author
|
@asinghvi17 - ready to be merged? |
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type variable in the
Meshconstructor was preventing JuliaC from being able to statically resolve types for trimming. Only use a type variable when the deprecatednormalsattribute is provided. Also fix the attribute name substitution! The previous logic had a bug in it that resulted in the code not actually substitutingnormalsfornormal.