Repository navigation
KernelInterface: wrap the shuffle test values of narrow types - #888
Merged
Merged
Conversation
With 64-wide sub-groups the shuffle tests use up to 133 work-items, and the values for the
`Tuple{Bool, Int8, Float16, UInt16}` field fallback converted `-i` to `Int8` with an
`InexactError` past 128, failing AMDGPU on MI250X and MI300A. Wrap it, and the `UInt8`
values that would fail the same way at width 128. Bump KernelInterface to 0.4.1.
Contributor
Benchmark ResultsShow table
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #888 +/- ##
=======================================
Coverage 82.59% 82.59%
=======================================
Files 28 28
Lines 2454 2454
=======================================
Hits 2027 2027
Misses 427 427 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With 64-wide sub-groups the shuffle tests use up to 133 work-items, and the values for the
Tuple{Bool, Int8, Float16, UInt16}field fallback converted-itoInt8, throwingInexactError: trunc(Int8, -129)while building the inputs. This fails AMDGPU.jl#1117 on MI250X and MI300A (CSCS); width-32 back ends never get past 69 work-items.Wrap that value, and the
UInt8values that would fail the same way at width 128. Bumps KernelInterface to 0.4.1, since the back ends run the test suite from the registered package.