Skip to content

Define hash for PointSpace and DiracSpace #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jishnub merged 1 commit into from
Sep 2, 2026
Merged

Define hash for PointSpace and DiracSpace #698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Spaces/DiracSpace.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ for TYP in (:DiracSpace,:PointSpace)
spacescompatible(a::$TYP,b::$TYP) = a.points == b.points
canonicalspace(a::$TYP) = a

Base.hash(a::$TYP, h::UInt) = hash(a.points, hash($TYP, h))

union_rule(a::$TYP,b::$TYP) = $TYP(sort(union(a.points,b.points)))

function coefficients(cfs::AbstractVector,fromspace::$TYP,tospace::$TYP)
Expand Down
18 changes: 18 additions & 0 deletions test/SpacesTest.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,24 @@ using Test
f = Fun(PointSpace(1:4), ones(4))
@test ApproxFunBase.isconstantfun(f)
end

@testset "hash" begin
DS = ApproxFunBase.DiracSpace
for T in (PointSpace, DS)
a, b = T(1:2), T(1:2)
@test a == b
@test hash(a) == hash(b)
@test isequal(a, b)
@test length(Set([a, b])) == 1
@test Dict(a => 1)[b] == 1
@test Set([T(1:2), T(3:4)]) == Set([T(3:4), T(1:2)])
@test hash(T(1:2)) != hash(T(3:4))
@test T([1, 2]) == T([1.0, 2.0])
@test hash(T([1, 2])) == hash(T([1.0, 2.0]))
end
@test PointSpace(1:2) != DS(1:2)
@test hash(PointSpace(1:2)) != hash(DS(1:2))
end
end

@testset "DiracSpace" begin
Expand Down
Loading