Repository navigation
fix(statechart): restore the upstream skill byte for byte - #29
Conversation
The port changed five upstream statechart files: the SKILL.md wording, a type annotation in run.ts, async wrappers in cli.test.ts, 101 lines of pipeline tests, and the render test's npm setup. Restore all five to the cursor/plugins 0.15.36 bytes so the skill works as the original does. Root tsc now skips skills/statechart/scripts, which keeps upstream's own tsconfig.json. The four statechart verification classes and their adaptation records are gone, and the inventory digest is repinned. The render test installs pele, mermaid, and jsdom itself, so the root no longer pins them. Proofs are regenerated for the changed lockfile.
|
Verdict: PASS+NOTES Head f713a84 against base f59b85d. Verified independently in detached worktrees under /tmp, both installed with
NOTE. The body says the statechart's own NOTE. No gate in this repo typechecks the statechart scripts now. The Node suite covers them behaviorally and the body states that upstream does not typecheck them either, so this is a deliberate trade. Flagged for whoever owns the subtree next. |
Why
/statechartshould match Lauren Tan's P Stack 0.15.36 skill and work the way the original does. Our port changed five upstream statechart files, so the skill no longer matched its source. This PR restores them byte for byte.What changed
SKILL.md,scripts/run.ts, and three test files matchcursor/pluginsat1ba91fcagain. Theskills/statecharttree hash isa79a48con this branch and at the pinned upstream commit.tscskipsskills/statechart/scripts, which keeps upstream's owntsconfig.json. The statechart adaptation records and verification classes are removed, and the digest is repinned.pele,mermaid, andjsdomitself, as upstream does, so the root no longer pins them.Scope
docs/guide/06-verify-and-ship.mdandcreate-formal-verification-skill, because those files carry other OMP changes.tscno longer typechecks the statechart scripts. The upstream bytes fail strict roottscinrun.tsandcli.test.ts, and upstream does not run a typecheck on them. The Node suite still covers them.Blast Radius
Only
/statechartand the root test command change. The skill needsmiseonPATHby default, as upstream does. The render tests now neednpmand network access.Verification
TLA2TOOLSandJAVAunset, mise installed Temurin 25 and TLC 1.7.4, and the skill checked a model with exit 0. A headless OMP run of the restored skill modeledsrc/runner.ts, ran TLC, and rendered a Pele SVG with no manual Java search or download.bun run testpasses: 471 Bun tests, then 267 Node tests with 67 live TLC tests skipped. With mise's TLC and Java exported, the Node suite runs 367 of 367 with none skipped.bun run typecheckandbun run check:contentpass. The proofs were regenerated on the pinned 18.10.2 SDK CLI. Two independent reviews confirmed the README claims.