Repository navigation
Fix clean installation and reject blank generation inputs - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and resulting behavior
CI installation failed because setuptools discovered both
appandmigrationsas top-level packages. A clean install then lacked the greenlet dependency required by SQLAlchemy asyncio. Generation requests also accepted blank model IDs and whitespace-only messages.Closes #2.
Changes
appand its subpackages; declaresqlalchemy[asyncio].Validation
Reproduced both installation failures and baseline whitespace-only acceptance. A fresh
pip install -e ".[dev]"now succeeds. 47 tests passed; Ruff lint/format checks passed; mypy reported no issues across 40 source files. Provider and webhook tests use mocks; no live paid-provider calls were made.Review focus
Check package inclusion and async dependency declarations. Message content must remain byte-for-byte unchanged when it contains non-whitespace text.