Skip to content

Fix clean installation and reject blank generation inputs - #3

Merged
Jemade merged 1 commit into
mainfrom
fix/package-install-and-generation-validation
Oct 4, 2026
Merged

Jemade merged 1 commit into
mainfrom
fix/package-install-and-generation-validation

Conversation

@Jemade

@Jemade Jemade commented Oct 4, 2026

Copy link
Copy Markdown
Owner

Problem and resulting behavior

CI installation failed because setuptools discovered both app and migrations as top-level packages. A clean install then lacked the greenlet dependency required by SQLAlchemy asyncio. Generation requests also accepted blank model IDs and whitespace-only messages.

Closes #2.

Changes

  • Explicitly package app and its subpackages; declare sqlalchemy[asyncio].
  • Reject whitespace-only model IDs and content; trim valid model IDs while preserving message indentation and line breaks.
  • Add five validation regressions, contributor instructions, issue forms and a PR template, linked from the README.

Validation

Reproduced both installation failures and baseline whitespace-only acceptance. A fresh pip install -e ".[dev]" now succeeds. 47 tests passed; Ruff lint/format checks passed; mypy reported no issues across 40 source files. Provider and webhook tests use mocks; no live paid-provider calls were made.

Review focus

Check package inclusion and async dependency declarations. Message content must remain byte-for-byte unchanged when it contains non-whitespace text.

@Jemade
Jemade merged commit 76f199e into main Oct 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix CI package installation and blank generation inputs

1 participant