Skip to content

Split scan_repo, _folder and _entry (CC 17–18) below CC 15 #51

Description

@tschm

rhiza

Subcategory: code complexity — 7 → 8

After #39 removed every D-ranked block, uvx radon cc jq_collector -s -nc still reports 11 blocks at rank C. The worst three:

  • jq_collector/localgit.py:234 scan_repo — CC 18
  • jq_collector/repos.py:124 _folder — CC 17
  • jq_collector/repos.py:258 _entry — CC 17

(Others: repos.py:349 load 14, github.py:528 collect 14, github.py:245 active_workflows 14, localgit.py:348 scan 14, gitlab.py:391 collect 13, github.py:287 latest_runs 11, github.py:343 coverage_artifact 11, metrics.py:550 _add_local 11.)

Change: extract the independent checks in these three functions into named helpers, as #39 did for metrics.render. The 100% coverage floor and the golden exposition keep the behaviour fixed.

Done when radon reports no block above CC 14 in jq_collector, and coverage stays at 100%.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions