Repository navigation
Fix exact C# coverage exits and prepare coherent 0.4.3 source - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approved C# nonzero returns were reported as partial coverage because Coverlet 8.0.1 collapses the target exit into its own failure code. Version 0.4.3 runs a fixed isolated Python bridge that waits for the real instrumented .NET child and exclusively records its exact return, source, case and stdin binding. The worker independently requires collector success, a valid fresh observation and real coverage XML; unexpected exits and genuine collector errors/timeouts remain failures.
The current compiler lane now requires measured C# cases and separate target/collector evidence. It exercises exits 0/1/2/7/255, malformed input, an incorrect expected return, an exception and real collector argument rejection, post-target report-write failure and timeout. The immutable 0.4.2 baseline and published package test preserve the historical limitation through an explicitly source-bound policy.
Focused tests cover actual inert child-process behavior and strict request/receipt/measurement failures; only hosted Actions executes .NET/Coverlet. Native package tests require the exact bundled bridge bytes. Source/application/worker versions are coherently 0.4.3 with unchanged dependencies. The owner's installed app, data and Docker are not modified, and existing 0.4.2 release assets are not overwritten.
Validation: both hosted source lanes passed 70 realistic scenarios; current C# exits 0/1/2/7/255/2 were measured, and all three genuine collector faults were blocked. Full hosted suite: 410 tests and 28 subtests passed, with 85.01% controller/training coverage against the unchanged 80% floor. Browser, isolated worker/fuzz, private-history replay, native packages on three operating systems and CodeQL passed. Focused local suite: 238 passed and two explicit Windows platform skips. No new release or local upgrade is claimed.
Detailed design and dated run/source evidence: docs/csharp-coverage.md and docs/reports/csharp-coverage-2026-11-10.md.