Repository navigation
ci(release): key release notes on the real type labels, not just dependencies - #735
Conversation
|
✅ GOOD TO MERGE @ |
|
✅ GOOD TO MERGE @
Nothing found changes where any PR actually files, and the flagged risk (review labels in ✅ GOOD TO MERGE @ |
…ndencies Every merged PR now carries a type label (zero exceptions), so the old two-category split (Dependencies / catch-all) is stale -- its own comment cited a 40-PR survey where only Dependabot labelled anything, which is no longer true. - Add one category per type label (13 total incl. catch-all), ordered from a 334-PR label-overlap survey so breaking always outranks fix/feat/release/ci, and release outranks ci/fix/dependencies for old "New distribution" PRs. - Move dependencies to second-to-last (was first) so a future PR mixing a real change with a dependency-bump label surfaces under the real category. - Document why review: labels must never key a category or appear in any exclude.labels -- either would drop every reviewed PR from the notes. No code path touched; pure YAML config, so no coverage delta and no test. Validated: YAML parses, schema matches GitHub's documented release.yml keys, and PR label combinations traced against the new ordering by hand.
c1517a8 to
ecf57f9
Compare
|
Re-measured the comment's numbers directly (
Config itself (12 categories, order, no |
|
✅ GOOD TO MERGE @ |
|
✅ GOOD TO MERGE @ Narrow re-check; supersedes the New head parses: 13 categories, each exactly
Commit message now agrees with the file ( Two caveats, neither blocking: L43 cites No test run, deliberately: a comment-only change to a config file with no import path, so the coverage rule genuinely does not apply here rather than being quietly skipped. ✅ GOOD TO MERGE @ |
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort) — N/A, no Python touchedmake testpasses, and a test case covers the changeAdded a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible — N/A — changelog centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingchore— anything elseDescription of your pull request and other information
Replaces the two-category
.github/release.yml(Dependencies / catch-all) with one categoryper type label, now that all 499 merged PRs carry a reliable type label. Order is derived from
a 330-PR survey of label overlaps:
breakingfirst so it never gets buried underfix/release/ci;releasesecond so old "New distribution" PRs land there and not underci/fix/dependencies;dependenciesmoved from first to second-to-last (judgement call, reasoning inthe file's own comments — flip it if wrong).
review:*labels documented as never eligible fora category or an
exclude.labelsentry, since either would drop reviewed PRs from the notes.Pure YAML config, no code path — no coverage delta, no test to add. Validated: YAML parses,
schema checked against GitHub's documented
release.ymlkeys (categorytitle+labelsonly,no invented keys), and label combinations traced by hand against the new ordering (see PR
description / session report for the traces, e.g. #691 breaking+fix → Breaking, #21 release+ci
→ Release).
actionlintwas not available in this environment to also check it.