Skip to content

ci: stop a TestPyPI outage from costing the release its wheels #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JarryShaw merged 1 commit into from
Sep 19, 2026
Merged

ci: stop a TestPyPI outage from costing the release its wheels #498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/create-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,9 @@ jobs:
needs: [ github, version_check ]
if: ${{ startsWith(github.ref_name, 'v') || needs.version_check.outputs.PCAPKIT_TAG_EXISTS == 'false' }}
strategy:
## one leg failing must not cancel its siblings: each leg still has its own
## wheel to attach to the GitHub Release, and a cancelled leg never does
fail-fast: false
matrix:
python-version:
- "3.10"
Expand Down Expand Up @@ -234,7 +237,12 @@ jobs:
skip-existing: true
attestations: false

## TestPyPI is a secondary target and its availability must not gate the
## real release. A transient ``test.pypi.org`` read timeout failed the
## 1.5.0b2 Python 3.12 leg *after* PyPI had already accepted the upload,
## which skipped the GitHub Release step below and lost that wheel.
- name: Publish package to TestPyPI
continue-on-error: true
uses: pypa/gh-action-pypi-publish@release/v1
with:
# password: ${{ secrets.TEST_PYPI_API_TOKEN }}
Expand Down
Loading