[JarryShaw]

• Searched for similar pull requests
• Followed the coding style
• make test passes, and a test case covers the change
• Changelog entry: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657

What is the purpose of your pull request?

• docs — documentation only

---

Description

Part of #1103, ruling 1: the narratives in tests/project/ say what the code does now, not how a change got it there. #2199 owns test_python_versions_1660.py and test_resource_monitor_1740.py, so this PR leaves them out.

• Rewrites:
  • "now" and "no longer" go.
  • "used to …" and "Before #NNN" become the defect each test guards against, or a condition such as "a generator without the retry (fix(examples): retry the Wireshark sample downloads on HTTP 429 before falling back to the stand-in #1658)".
  • Pure history is cut. The biggest cut is the test_isort_clean docstring's three-fix story, which becomes three bullets on why the Makefile lines are shaped as they are.
• Stale claim corrected: test_conda_no_windows_steps_1967 said the conda jobs have no Windows leg. Both have had one since Conda: bring back the Windows (win-64) package, in two phases #2060.
• Kept:
  • "now" where it means the present moment.
  • Third-party facts.
  • Fixtures of a former config, which are inherently historical.
  • Change-relative assertion messages, step names and subTest labels, which are code.
• Scope: comments and docstrings only. With docstrings stripped, every changed file has main's AST.
• Tests run: all changed files in three batches (314, 174, 548 passed), with the tier guard, the docstring contract and the issue-reference scanner.
• Overlap: docs(util): document that CITATION.cff dates a release by its version bump (#2163) #2194 and docs(ci): cite python-versions.toml keys and recorded defects by name (#2165) #2199 each share a file, and both merge cleanly.

[JarryShaw]

Review: NEEDS CHANGES at 9ac00865e (Sonnet). Two prose comments are still change-relative: the #: comment's "before #2040" in test_unit_tests_push_reports_2030.py, and "where a bare struct.error used to" in test_conventions_doc_claims.py. The opening of test_conda_no_windows_steps_1967.py's docstring is also garbled. Everything else checks out: present-tense claims hold, including both conda Windows legs, the AST check is clean, and the tests pass. The worker is fixing the three items.

[JarryShaw]

Review fixes pushed: 9ac00865e → 9463a15f5, rebased onto main.

• test_unit_tests_push_reports_2030.py: the "before ci: Python pypy3.10 (KTLO) cannot install, since cryptography has no pp310 wheel past 46.0.3 #2040" #: comment now states the list's purpose.
• fix(fields): raise ProtocolError, not struct.error, on a negative resolved field length #811 comment: now states the page's claim.
• test_conda_no_windows_steps_1967.py: the docstring opening says what the test guards against.
• grep -cw sentence: now names the approach being guarded against.

The AST check is clean, and the touched files pass their tests. A delta review is running.

[JarryShaw]

Review: GOOD TO GO at 9463a15f5 (Sonnet delta). All four items are fixed, and range-diff shows nothing else moved. The AST check is clean, and the touched files pass along with the tier guard and the docstring contract (245). A few remaining "pre-#910" / "pre-fix" phrases, which describe a mutation measurement or fixture, are logged for the next #1103 round.

[JarryShaw]

Ready to merge at 9463a15f5. Part of #1103 (ruling 1).

• Review: Sonnet GOOD TO GO, after a NEEDS CHANGES round.
• CI: all checks complete, Required checks passed SUCCESS, 0 failed.
• KTLO: 12 legs, no warnings.
• Ordering: project leg merged into main, 2290 tests, 0 failures.
• Conflicts: none with the current main.

[github-actions]

Coverage: 91.55% (unit tier, Python 3.15, 9463a15f5, Unit Tests run success)

Package	Statements	Missed	Branches	Partial	Cover
pcapkit (top level)	104	4	20	2	95.16%
pcapkit/const	19599	881	2618	867	92.11%
pcapkit/corekit	2589	75	816	37	96.48%
pcapkit/dumpkit	282	3	102	3	98.44%
pcapkit/foundation	2971	23	1036	25	98.80%
pcapkit/interface	138	4	52	3	96.32%
pcapkit/protocols	17433	219	4584	185	98.15%
pcapkit/toolkit	869	36	298	10	95.20%
pcapkit/utilities	504	7	146	5	98.15%
pcapkit/vendor	4432	1988	1018	167	51.87%

Per-file detail: the coverage-html artifact of this run.