Repository navigation
fix(protocols): correct 'timestmap' and 'movile' in two messages (#2171) - #2189
Merged
Merged
Conversation
TSOption.post_process warned of an "unknown timestmap flag", and MH._make_opt_mnp raised on an "invalid movile network prefix". Spell them "timestamp" and "mobile". Test: test_message_spelling_2171_unit packs a timestamp option with flag 2 and builds a mobile network prefix option from an IPv4 prefix, and checks each message's spelling.
JarryShaw
added
bug
Owner
Author
|
Review: GOOD TO GO at |
JarryShaw
added
review: good-to-go
Owner
Author
|
Ready to merge at
|
Contributor
|
Coverage: 91.55% (unit tier, Python 3.15,
Per-file detail: the |
JarryShaw
removed
the
review: good-to-go
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix— corrects a defectDescription
Closes #2171.
pcapkit/protocols/schema/internet/ipv4.py), and "movile" becomes "mobile" in the MH mobile network prefix error (pcapkit/protocols/internet/mh.py). A grep finds no other copies.tests/protocols/internet/test_message_spelling_2171_unit.py. Onmainboth cases fail, e.g.'unknown timestamp flag: 2' not found in '… unknown timestmap flag: 2'.test_ipv4_unit,test_mh_unitand the tier guard pass (213).mh.py; the two merge cleanly.