Repository navigation
fix(hip): build the ECHO_RESPONSE_UNSIGNED schema in its maker (#2170) - #2188
Merged
Merged
Conversation
HIP._make_param_echo_response_unsigned returned a Schema_EchoRequestUnsignedParameter, and its param and return annotations named the Request classes. The wire output was right, since the type code is passed through; the in-memory schema class was not. Use Schema_EchoResponseUnsignedParameter and Data_EchoResponseUnsignedParameter. Test: test_hip_echo_response_unsigned_maker_builds_the_response_schema checks the schema class from both keyword and data input, and the annotations.
JarryShaw
added
bug
Owner
Author
|
Review: GOOD TO GO at |
JarryShaw
added
review: good-to-go
Owner
Author
|
Ready to merge at
|
Contributor
|
Coverage: 91.55% (unit tier, Python 3.15,
Per-file detail: the |
5 tasks done
JarryShaw
removed
the
review: good-to-go
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix— corrects a defectDescription
Closes #2170.
HIP._make_param_echo_response_unsignedbuilt and was annotated withSchema_EchoRequestUnsignedParameterandData_EchoRequestUnsignedParameter, a copy-paste from the request maker.EchoResponseUnsignedschema and data classes.test_hip_echo_response_unsigned_maker_builds_the_response_schemaintests/protocols/internet/test_hip_unit.py. Onmainit fails withEchoRequestUnsignedParameter is not EchoResponseUnsignedParameter.tests/protocols/internet/test_hip*.pypass (75).hip.py; the two merge cleanly.