Repository navigation
ci(release): run version_check's tier and completeness reads from util/ scripts (#1967) - #2081
Conversation
|
GOOD TO GO at
|
|
Coverage: 91.54% (unit tier, Python 3.15,
Per-file detail: the |
|
Ready to merge at |
Step 2 of #1967, third batch for create-release.yml: three of version_check's inline shell steps move into stdlib-only scripts, on the python3 setup-python puts first on PATH, with each step's name, id and env: unchanged; only the run: bodies differ. Get Version stays inline. * util/release_tiers.py: "Read the released Python versions", with #2079's copy of the released commit's util/_actions.py, where it has one. * util/release_published.py pypi|anaconda: "Check PyPI publish completeness" and "Check Anaconda publish completeness", which shared all but endpoint, expectation and count. Same curl, URLs and /tmp paths. * workflows.rst lists both scripts. tests/project/test_release_version_check_scripts_1967.py runs each former shell, kept verbatim, and its script on the same cases against stand-in python3, git, mktemp and curl, requiring the same status, output, $GITHUB_OUTPUT, calls and scratch files; the tables reach every exit and path of each shell, and planted divergences are caught. The tests that ran or pinned the shell now run or read the scripts.
|
Rebased onto
The diff changed, so a delta review is running. |
e22a31a to
b4831a8
Compare
|
GOOD TO GO at
|
|
Ready to merge at |
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
ci— changes to CI configuration files and scriptsDescription of your pull request and other information
The third create-release batch for #1967, covering three of
version_check's steps.util/release_tiers.py: Read the released Python versions.util/release_published.py pypi|anaconda: both publish-completeness checks. It keeps the same curl arguments (-s --retry 3 --retry-connrefused), URLs,|| echo 000handling and/tmpreply paths.set -x, and a script that reproduced the trace would have cost far more than it saved.run:values changed. The job already checks out the full tree and sets up Python first. actionlint 1.7.12 is clean.test_release_version_check_scripts_1967embedsmain's three bodies verbatim and runs each underbash -eside by side with its script, using stand-incurl/git/python3. It requires the same status, stdout, stderr, outputs, calls and scratch files. Its cases reach every exit of each old step, and 12 planted divergences were caught. It also passes under bash 5.2.Overlap: #2079 also adds to the
SCRIPTStuple, so whichever merges second gets a small rebase.