Skip to content

ci: trim comments in lint.yml (#1967) - #2068

Merged
JarryShaw merged 1 commit into
mainfrom
ci/1967-trim-lint
Oct 23, 2026
Merged

JarryShaw merged 1 commit into
mainfrom
ci/1967-trim-lint

Conversation

@JarryShaw

Copy link
Copy Markdown
Owner

What is the purpose of your pull request?

  • ci — changes to CI configuration files and scripts

Description of your pull request and other information

Part of #1967, in the same shape as #2059. This trims lint.yml's comments to the why and the constraints.

  • Removed: the PYLINT_FLAGS history (PYLINT_FLAGS loads a plugin that does not exist, so compare-to-empty-string never runs #767), a "measured at" note, the list of PRs that fixed actionlint's findings, a repeated continue-on-error explanation, and the run-report narration.
  • Kept: every reason, every #NNN ref, the ruleset id, the actionlint pin and -ignore rationale with their upstream links, the vermin blocker, and the promotion order. The header sentence saying isort runs only in cron-vendor.yml also stays, because test_isort_clean and test_tier_guard cite it.
  • Comments only: yaml.safe_load of main's file and this one compare equal, and every non-comment line is identical and in the same order.
  • Tests: the workflow readers (actionlint, lint/pages reports, at-a-glance, conventions, KTLO guard, pins, isort, tier guard) all pass.

Drop narration and history the issues already hold (#767's flag cleanup, the
measured-at notes, the finding-fix list) and tighten the rest; no YAML changes.
@JarryShaw JarryShaw added ci Pull requests that change CI or workflow configuration (ci: subject prefix) review: running A cross-review is in flight against the current head - no verdict yet labels Oct 23, 2026
@JarryShaw

Copy link
Copy Markdown
Owner Author

GOOD TO GO at 3ac4ad3cb (Sonnet cross-review). The change is comments only: yaml.safe_load gives equal documents, every non-comment line is identical, and no other file changed. Every reason a maintainer needs is still there, including:

No remaining comment dangles, steps are cited by name, and the workflow tests pass (tier guard 130 passed; 359 passed in the project subset). The only loss is history: the #767 PYLINT_FLAGS paragraph explaining why R0022, W0012 and emptystring are absent.

@JarryShaw JarryShaw added review: good-to-go Cross-review at the current head says ready; CI state is separate and removed review: running A cross-review is in flight against the current head - no verdict yet labels Oct 23, 2026
@JarryShaw JarryShaw moved this to In review in PyPCAPKit Oct 23, 2026
@JarryShaw

Copy link
Copy Markdown
Owner Author

Ready to merge at 3ac4ad3cb: the review is GOOD TO GO and CI is complete (56 passed, 0 failed). The ordering leg ran 1991 tests with 0 failures. The 3.8–3.10 KTLO legs show 0 failing tests, and the PR is based on current main (fd0d2e724).

@github-actions

Copy link
Copy Markdown
Contributor

Coverage: 91.52% (unit tier, Python 3.15, 3ac4ad3cb, Unit Tests run success)

Package Statements Missed Branches Partial Cover
pcapkit (top level) 104 4 20 2 95.16%
pcapkit/const 19599 881 2618 867 92.11%
pcapkit/corekit 2565 71 812 37 96.56%
pcapkit/dumpkit 282 3 102 3 98.44%
pcapkit/foundation 2930 23 1022 25 98.79%
pcapkit/interface 138 4 52 3 96.32%
pcapkit/protocols 17414 219 4574 185 98.14%
pcapkit/toolkit 869 36 298 10 95.20%
pcapkit/utilities 473 7 136 5 98.03%
pcapkit/vendor 4431 1995 1018 167 51.73%

Per-file detail: the coverage-html artifact of this run.

@JarryShaw
JarryShaw merged commit 271534c into main Oct 23, 2026
64 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in PyPCAPKit Oct 23, 2026
@JarryShaw
JarryShaw deleted the ci/1967-trim-lint branch October 23, 2026 04:00
@JarryShaw JarryShaw removed the review: good-to-go Cross-review at the current head says ready; CI state is separate label Oct 23, 2026
@JarryShaw JarryShaw added this to the PyPCAPKit v1.5 milestone Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Pull requests that change CI or workflow configuration (ci: subject prefix)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant