Repository navigation
build: remove setup.py now that the floor is Python 3.8 (#2061) - #2066
Conversation
ef7387b to
15db89c
Compare
|
GOOD TO GO at Two non-blocking fixes are coming in one amend:
|
After #2053 setup.py was a Python 2 guard and a bare setup(); pyproject.toml declares everything, and the wheel builds the same files without it. - Delete setup.py and tests/project/test_setup.py. - Add tests/project/test_no_setup_py_2061.py: fails if setup.py returns, or if a COPY in examples/benchmark/Dockerfile names an untracked path. - examples/benchmark/Dockerfile: stop copying setup.py. - pyproject.toml, test_actions_pinned_1968: the static readme is now explained by Dependabot fetching pyproject.toml in setup.py's place (fetch_project_file) and passing it through unstubbed, not by its stub setup.py. - util/classify_changes.py, tests/_tiers.py: examples no longer name the removed files. - Changelog entry in 1.5.0.rst; CHANGELOG.md regenerated.
15db89c to
e80e32c
Compare
|
Pushed
|
|
Coverage: 91.52% (unit tier, Python 3.15,
Per-file detail: the |
|
Ready to merge at |
|
Still ready after #2064 merged. The branch is only BEHIND: it merges cleanly into |
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
build— changes that affect the build system or external dependenciesDescription of your pull request and other information
Closes #2061. Since #2053,
setup.pyheld nothing but a Python 2 guard and a baresetup(); everything else is declared inpyproject.toml.setup.pyandtests/project/test_setup.py.examples/benchmark/Dockerfileno longer copiessetup.py.main's exactly underdiff -r. The sdist loses only the two deleted files.pip install -e .works (PEP 660), andpip wheelon 3.8 succeeds.readmechanges. Dependabot's file fetcher (fetch_project_file) now builds the Pipfile's editable frompyproject.tomlalone, instead of from its stubsetup.py. The comment andtest_actions_pinned_1968are reworded to match.test_no_setup_py_2061fails ifsetup.pycomes back, or if a DockerfileCOPYnames an untracked path. A self-check stops the parser passing vacuously by finding nothing. I confirmed it fails before the fix in both of those ways.