Skip to content

fix(deps): cap cryptography below 46 on PyPy older than 3.11 (#2040) - #2046

Merged
JarryShaw merged 1 commit into
mainfrom
fix/2040-cap-old-interpreter-deps
Oct 22, 2026
Merged

JarryShaw merged 1 commit into
mainfrom
fix/2040-cap-old-interpreter-deps

Conversation

@JarryShaw

Copy link
Copy Markdown
Owner

What is the purpose of your pull request?

  • fix — corrects a defect

Description of your pull request and other information

Part 1 of #2040 (the owner's ruling: cap it). The 3.7 part is reported on the issue.

  • crypto and all now cap cryptography below 46, only on PyPy older than 3.11, using a complementary marker pair. PyPI's file lists show 45.0.7 is the newest release with a manylinux pp310 wheel. 46.0.0–46.0.3 have pp310 wheels only for macOS and Windows, and 46.0.4 and later have none. That makes my <=46.0.3 suggestion on the issue wrong for the Linux leg.
  • process.rst's pyproject listing (pinned by test_conventions_doc_claims), a sentence in workflows.rst and test_tier_guard's crypto spot check are all updated to match.
  • New tests/project/test_pypy310_cryptography_cap_2040.py evaluates both markers for PyPy 3.10, PyPy 3.11 and CPython 3.10. It fails on main's pyproject (2 failed) and passes here. The neighbouring tests: 168 passed.

#2036's EXPECTED entry for the pypy3.10 install annotation goes stale once this lands.

45.0.7 is the newest cryptography with a manylinux pp310 wheel, so the
pypy3.10 KTLO leg built the newest sdist and failed at install. The crypto
and all extras now carry a second, PyPy < 3.11 line capped below 46; every
other interpreter keeps the uncapped line.

tests/project/test_pypy310_cryptography_cap_2040.py evaluates both markers
for PyPy 3.10, PyPy 3.11 and CPython 3.10.
@JarryShaw JarryShaw added bug Issues reporting a defect (set by the bug report template; a default, not an assessment) dependencies Pull requests that update a dependency file python Pull requests that update Python code review: running A cross-review is in flight against the current head - no verdict yet labels Oct 22, 2026
@JarryShaw

Copy link
Copy Markdown
Owner Author

GOOD TO GO at 9a047569a (Sonnet cross-review).

  • Wheels: confirmed from PyPI JSON. 45.0.7 has manylinux pp310 wheels; 46.0.x have only macOS and Windows.
  • Markers: confirmed complementary across CPython, PyPy and GraalPy (GraalVM), 3.7–3.15. Exactly one line applies on every interpreter.
  • conda: util/conda_vendor.py handles both lines.
  • Tests: the new test fails on main's pyproject (2 failed). The reviewer's neighbouring set gives 223 passed, 1 skipped.

UNVERIFIED: a real pypy3.10 (KTLO) install, which only CI shows.

@JarryShaw JarryShaw added review: good-to-go Cross-review at the current head says ready; CI state is separate and removed review: running A cross-review is in flight against the current head - no verdict yet labels Oct 22, 2026
@JarryShaw JarryShaw moved this to In review in PyPCAPKit Oct 22, 2026
@JarryShaw
JarryShaw merged commit 8df1192 into main Oct 22, 2026
69 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in PyPCAPKit Oct 22, 2026
@JarryShaw
JarryShaw deleted the fix/2040-cap-old-interpreter-deps branch October 22, 2026 18:58
@JarryShaw JarryShaw removed the review: good-to-go Cross-review at the current head says ready; CI state is separate label Oct 22, 2026
@JarryShaw JarryShaw added this to the PyPCAPKit v1.5 milestone Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issues reporting a defect (set by the bug report template; a default, not an assessment) dependencies Pull requests that update a dependency file python Pull requests that update Python code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant