Repository navigation
fix(deps): cap cryptography below 46 on PyPy older than 3.11 (#2040) - #2046
Merged
Merged
Conversation
45.0.7 is the newest cryptography with a manylinux pp310 wheel, so the pypy3.10 KTLO leg built the newest sdist and failed at install. The crypto and all extras now carry a second, PyPy < 3.11 line capped below 46; every other interpreter keeps the uncapped line. tests/project/test_pypy310_cryptography_cap_2040.py evaluates both markers for PyPy 3.10, PyPy 3.11 and CPython 3.10.
Owner
Author
|
GOOD TO GO at
UNVERIFIED: a real |
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix— corrects a defectDescription of your pull request and other information
Part 1 of #2040 (the owner's ruling: cap it). The 3.7 part is reported on the issue.
cryptoandallnow capcryptographybelow 46, only on PyPy older than 3.11, using a complementary marker pair. PyPI's file lists show 45.0.7 is the newest release with a manylinuxpp310wheel. 46.0.0–46.0.3 havepp310wheels only for macOS and Windows, and 46.0.4 and later have none. That makes my<=46.0.3suggestion on the issue wrong for the Linux leg.process.rst's pyproject listing (pinned bytest_conventions_doc_claims), a sentence inworkflows.rstandtest_tier_guard'scryptospot check are all updated to match.tests/project/test_pypy310_cryptography_cap_2040.pyevaluates both markers for PyPy 3.10, PyPy 3.11 and CPython 3.10. It fails onmain's pyproject (2 failed) and passes here. The neighbouring tests:168 passed.#2036's
EXPECTEDentry for thepypy3.10install annotation goes stale once this lands.