Repository navigation
ci(conda): install Miniforge on the macos-26-intel legs (#2044) - #2045
Merged
Merged
Conversation
With no installer named, setup-miniconda downloads Miniconda3-latest-MacOSX-x86_64.sh on the Intel runner. That installer is frozen at conda 25.7.0, which fails "Install conda build tools" on a conflicting post_solves plugin and has no py314 build. The step "Conda environment creation and activation" of cron-conda.yml's conda-dist and create-release.yml's conda job now passes miniforge-version: latest on macos-26-intel, and an empty string, which names no installer, everywhere else. tests/project/test_conda_intel_miniforge_2044.py evaluates the step's installer inputs per matrix leg.
JarryShaw
added
bug
Owner
Author
|
GOOD TO GO at
UNVERIFIED: the exact conda version inside the 26.7.2-1 installer. Any conda from 26.3 on removes the conflicting hook. |
JarryShaw
added
review: good-to-go
Contributor
|
Coverage: 91.54% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
|
Ordering check on |
JarryShaw
removed
the
review: good-to-go
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
ci— changes to CI configuration files and scriptsDescription of your pull request and other information
Fixes 1 and 2 of #2044. The upload 404 (fix 3) is waiting on the owner's choice, so this PR does not close the issue.
cron-conda.ymlandcreate-release.ymlnow setsminiforge-version: lateston themacos-26-intellegs only. Miniforge 26.7.2 ships osx-64 with conda 26.7.2. That is newer than the 26.3 release where conda dropped its built-insignature-verificationhook, and it has a py314 build.''. setup-miniconda v4.1.0 treats an empty string as "no Miniforge" (src/installer/download-miniforge.tsat the pinned sha), so those legs keep their current installer.|| ''is required: without it the input isfalse, which would select Miniforge on every leg.tests/project/test_conda_intel_miniforge_2044.pyevaluates the installer inputs for each leg. It fails againstmain's workflows (2 failed, 4 passed) and passes on this branch (4 passed). The tests that read these workflows:756 passed, 1 skipped.PR CI never runs Conda Update, so the fix is only proven on the next run on
main.