Repository navigation
fix(utilities): leave GraalPy's bootstrap frames out of the importer's level, and gate its remaining limits (#1963) - #1996
Merged
Conversation
…s level, and gate its remaining limits (#1963) - _importer_stacklevel skips <frozen _frozen_importlib> and <frozen _frozen_importlib_external>, GraalPy's names for importlib's bootstrap frames, which its warnings.warn already leaves out; the import-time ConfigWarnings named <sys>:0 there - new ImporterStacklevelTests pins both interpreters' names on CPython - test_sentinel_py_abc_1960_unit: GraalPy takes the _py_abc fallback unaided, and its _py_abc imports from _abc, so the child blocks _abc only off GraalPy - test_compat: GraalPy words a UnicodeDecodeError's reason its own way, so there only the octet and position are compared; this is what failed UnmaskedOrderTests' unittest child - test_tier_guard_xdist: skip XdistSubprocessTests and ProbeWorkerCrashTests on GraalPy, whose nested xdist sessions idled the leg's other workers Touched modules pass on CPython 3.14 and GraalPy 25.4.4; the tier guard passes. Refs #1963
Owner
Author
|
GOOD TO GO at
The review also asked for |
JarryShaw
force-pushed
the
test/1963-graalpy-remaining
branch
from
October 20, 2026 18:46
30a584e to
f2944a2
Compare
Contributor
|
Coverage: 91.52% (unit tier, Python 3.15,
Per-file detail: the |
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix— corrects a defectDescription of your pull request and other information
The remaining GraalPy-only failures from #1963, each reproduced on GraalPy 25.4.4 locally.
_importer_stacklevelcounted GraalPy's<frozen _frozen_importlib…>bootstrap frames, which itswarnings.warnskips. An import-time warning was therefore attributed to<sys>:0. The newImporterStacklevelTestscover both interpreters' frame names, and fail without the fix.test_sentinel_py_abc_1960_unitblocks_abconly off GraalPy, because GraalPy's_py_abcimports from_abc.test_compatcompares only the octet and position of aUnicodeDecodeErroron GraalPy, which words the error differently.XdistSubprocessTestsandProbeWorkerCrashTestsskip on GraalPy.test_extraction_no_eofand the large-declared-length field test already pass after fix(corekit): copy SeekableReader's octets and feed MultiDict a dict, and gate GraalPy's limits (#1963) #1974/fix(foundation): a record length above sys.maxsize crashes Frame.read with OverflowError on 32-bit-Py_ssize_t builds #1975.preexec_fnandSOCK_SEQPACKETmodules are in theLATESTtier, so the GraalPy leg never runs them.Not done:
util/python_versions.py, and a shard would rename the check.timeout, so re-measure after merge first.__del__, soExtractor.__del__cannot close an abandoned extraction's file there.Part of #1963.