Repository navigation
ci(experimental): count raised MemoryErrors, not mentions of one (#1962) - #1972
Merged
Merged
Conversation
- Run unit tests: count the lines that MemoryError heads, at the line's start or after pytest's E, an INTERNALERROR> or an exception group's |, instead of every word match, which counted a test docstring a traceback printed and warned of a MemoryError on every GraalPy timeout. - Pin it: a docstring, source line or Java OutOfMemoryError mention is not counted; a raised MemoryError, #1753's included, is. - Say so in the step's comment and the workflows page. Closes #1962
Owner
Author
|
GOOD TO GO at |
Contributor
|
Coverage: 90.07% (unit tier, Python 3.15,
Per-file detail: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
ci— workflows or build toolingDescription of your pull request and other information
The GraalPy leg warned
tests raised MemoryErrorwhenevergrep -cw MemoryErrorfound a match. That grep also matched a test docstring printed inside a traceback, so every timed-out run warned of a MemoryError that was never raised (#1962).MemoryErrorheads: at line start, or after pytest'sE,INTERNALERROR>, or an exception group's|.tests/project/test_memory_error_count_1962.pyruns the real step: mentions count 0 and raised forms count 1. It fails without the fix.Closes #1962