Repository navigation
docs(const): link aenum through the epilog in the apptype and option_type templates (#1920) - #1945
Merged
Merged
Conversation
…type templates (#1920) - Write the package-level aenum mention in the AppType docstring as |aenum|_, the rst_epilog link (#1936), and demote member-level aenum roles in the AppType and OptionType templates to qualified literals (#934 part C). - Regenerate pcapkit/const/reg/apptype/apptype.py and pcapkit/const/pcapng/option_type.py byte-identically from the committed crawled data. - Lift the template and pcapkit/const/ exclusions from the #1919 and #1936 guards, so both now scan these files. Closes #1920
JarryShaw
added
docs
This was referenced Oct 19, 2026
Owner
Author
|
GOOD TO GO at |
JarryShaw
added
review: good-to-go
JarryShaw
removed
the
review: good-to-go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
docs— documentation onlyDescription of your pull request and other information
Converts the aenum roles left in the AppType and OptionType templates and their const modules (#1920). The package mention becomes
|aenum|_(#1936); member names and#comments become qualified literals (#934 part C). Both const modules regenerate byte-identically from the committed crawled data.The #1919 and #1936 guards no longer exclude these files. With main's four files swapped in, the #1919 guard fails on every converted site. The tier guard,
tests/const,tests/vendorandtests/projectpass, and the pinned docs build has 0 warnings.Closes #1920