Repository navigation
test(protocols): drop test_mh_unit's dead tracebacklimit cleanup (#1924) - #1937
Merged
Merged
Conversation
Owner
Author
|
GOOD TO GO at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change — deletes a dead cleanup, so there is no new test;test_mh_unitpasses alone and alongsidetests/utilitiesAdded a changelog entry — N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657
test— tests onlyThis drops
test_mh_unit's_drop_tracebacklimitcleanup and theimport systhat only it used. Since #362, no pcapkit code setssys.tracebacklimit:git grepfinds only docstrings. The cleanup also deleted the attribute whenever it existed, which would remove a value the test runner had set. The test files that do touchsys.tracebacklimitsave and restore it themselves.Closes #1924