Repository navigation
Conversation
|
Verdict: NEEDS CHANGES at
|
fcbaf91 to
3549e07
Compare
|
Verdict: GOOD TO GO at The counts are gone: "three errors" in The three touched test files pass. Every functional finding from the review of |
3549e07 to
efa8c21
Compare
…pts (#1894) - util/ci_timing.py: fetch through a requests session; an HTTPError's status decides the retry and the 404 note, the Link header is parsed as requests parses it, and the token staying off a cross-host redirect is tested against loopback servers. ci-timing.yml installs requests and lxml. - util/update_python_versions.py: fetch() uses requests and parse_images() reads the runner-images table with markdown-it-py, so an escaped pipe stays in its cell; both import lazily, so `publish` still runs on a bare python3. The detect job installs both. - examples/generators/pcapng.py: download with requests, keeping the retry, Retry-After and offline fallback; a timeout mid-body is still retried. - util/vendor_test_gate.py: sample a run's process group with psutil, and with ps where psutil is not installed. - util/ci_timing.py parse_junit() and util/pyshark_encap_map.py's PDML read: lxml with a hardened parser instead of ElementTree, no fallback; the tests that parse are gated on HAS_LXML. - pyproject.toml: the test extra carries psutil (CPython only), markdown-it-py and lxml (not on GraalPy). - Pipfile [dev-packages]: the same, with the test extra's markers, pinned by a test. Closes #1894
efa8c21 to
3a7a1cd
Compare
|
Verdict: GOOD TO GO at
Sonnet re-reviews checked each amend:
|
|
Coverage: 90.07% (unit tier, Python 3.15,
Per-file detail: the |
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseThese follow the owner's requests on #1885.
util/ci_timing.py,util/update_python_versions.pyandexamples/generators/pcapng.py. The pcapng generator keeps its retry, Retry-After and offline fallback. A test against loopback servers showsci_timing.pystill keeps the token off a redirect to another host.parse_images()reads the runner-images README table with it, so an escaped pipe stays in its cell.parse_junit()and the PDML read inutil/pyshark_encap_map.pyuse it, through a parser that resolves no entities and makes no network access. There is no ElementTree fallback, and the tests that parse skip on GraalPy, which has no lxml wheel.util/vendor_test_gate.pysamples the test run's process group with it, and falls back topson PyPy and GraalPy, which have no psutil wheel.testextra gains these three packages.ci-timing.ymlinstalls requests and lxml, and thedetectjob installs requests and markdown-it-py.update_python_versions.py publishstill runs on a barepython3.tests/projectand the tier guard pass.Closes #1894