Repository navigation
ci(release): key a run with nothing to release on its own run id (#1705) - #1722
Merged
Merged
Conversation
- create-release.yml: a workflow_run whose Vendor Update did not conclude success, which version_check skips, now takes the concurrency group create-release-<run_id> instead of create-release-<ref>, so it can no longer cancel a pending run that may release. Runs that may release still share the ref's group and never cancel one in progress. - Rewrite the group's comment to state what it guarantees; same line count, so every create-release.yml:N citation in the docs still lands. - releasing.rst and workflows.rst (Skip Cascade) describe the gate. Tests: tests/project/test_release_concurrency_1705.py (fails 10 on origin/main) and the citation anchors in test_unit_tests_queue.py; release gates, verdict, #1634 and tier project tests pass. Closes #1705
Owner
Author
|
Verdict: GOOD TO GO at
|
Contributor
|
Coverage: 89.42% (unit tier, Python 3.15,
Per-file detail: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseDescription of your pull request and other information
Closes #1705.
successreleases nothing, becauseversion_checkskips it. Such a run is now keyed on its owngithub.run_id, so it can no longer cancel a pending run that may release. Tag pushes, and runs that may release, keep their ref's group andcancel-in-progress: false.github.event.workflow_run.conclusionis already set when GitHub computes the group name. The docs list thegithubcontext as available there, and three workflows already key a group ongithub.event.workflow_run.head_sha. After merge, two back-to-back successful Vendor Updates should queue rather than run in parallel.tests/project/test_release_concurrency_1705.pyfails 10 sub-cases againstmain's workflow and passes here. The release, tier and doc-citation tests intests/projectpass (261 + 50 + 131). actionlint reports no new finding.