Repository navigation
fix(ci): Vendor Update commits the new modules a crawl adds (#1685) - #1688
Merged
Merged
Conversation
Commit changes ran `git commit -am`, which never stages an untracked file, so a module generated for a new registry was bumped for but left out of the commit, and every later crawl bumped for it again. The step now runs `git add -A -- 'pcapkit/const/*.py'` first: new, modified and deleted modules, nothing outside pcapkit-vendor's output. Commit documentation changes keeps `-a` alone, since a new or deleted module always classifies as code. tests/project/test_vendor_commits_new_modules_1685.py runs the step's script in a scratch repository; both tests fail on origin/main.
Owner
Author
|
Verdict: GOOD TO GO at The fix is one line before Vendor Update's commit:
The reviewer built its own harness, with new modules at depths 2, 4 and 6, a modified one, a deleted one, and five stray files. Only the crawl's output was committed. The test's four mutations (unquoted pattern, a bare This merges cleanly with #1677. |
Contributor
|
Coverage: 89.46% (unit tier, Python 3.14,
Per-file detail: the |
3 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change — two new tests cover it; not the fullmake test, but the 12 relatedtests/project/tests/vendormodules (358 tests) passAdded a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible — N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseDescription of your pull request and other information
Commit changesincron-vendor.ymlrangit commit -am, which never stages an untracked file.verify-changed-files@v17does report one (the??lines ofgit status -u --porcelain, per itsentrypoint.sh). So a module generated for a new registry got a bump but was left out of the commit, and every later crawl bumped for it again.git add -A -- 'pcapkit/const/*.py'beforegit commit -am. That stages new, modified and deleted modules, and-astill picks up the files the bump rewrites. The pattern is quoted so git matches it at any depth; unquoted, the shell would expand it topcapkit/const/__init__.pyalone. It is limited to.pyso a.<module>.py.XXXX.bakthat_snapshot_and_restorecould not remove is not committed:.gitignoredoes not cover those.Commit documentation changes(ci(vendor): commit a comment-only regeneration without bumping the version (#1674) #1684): no gap there. The classifier calls a new or deleted file code, so that run takes the bump path. A test walks the steps to show this, and the step keeps-a.tests/project/test_vendor_commits_new_modules_1685.pybuilds on ci: Vendor Update bumps a beta on a regeneration that changes only comments #1674's harness. It runs the step's script in a scratch repo holding a new, a modified and a deleted module plus two stray files, and checks that exactly the modules and the bumped__init__.pyland in the commit. A second test checks that once a new module is committed, the next crawl reports nothing. Both fail onorigin/mainand pass here. A mutation check confirms each test catches an unquoted pattern, a whole-directory add, a repo-wide add, and a missing add.releasing.rstandworkflows.rsteach gain a sentence.actionlintreports no new findings (its 4 shellcheck notes are already onmain).Closes #1685