Skip to content

fix(toolkit): pypcapfile TCP reads past VLAN tags, warns of tunnels, skips later fragments and padding (#1537, #1576, #1577) #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JarryShaw merged 1 commit into from
Oct 10, 2026
Merged

fix(toolkit): pypcapfile TCP reads past VLAN tags, warns of tunnels, skips later fragments and padding (#1537, #1576, #1577) #1575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions docs/source/pcapkit/foundation/engines/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,11 @@ offers, and the ones that cannot say so rather than quietly doing less:
| :class:`~pcapkit.foundation.engines.pypcapfile.PyPCAPFile` | no IPv6 decoder, hence no IPv6 reassembly -- disabled with an |
| | :class:`~pcapkit.utilities.warnings.AttributeWarning`, and |
| | :func:`~pcapkit.toolkit.pypcapfile.ipv6_reassembly` raises; |
| | TCP over IPv6 is left out of TCP reassembly and flow tracing, |
| | with an :class:`~pcapkit.utilities.warnings.AttributeWarning` |
| | once per capture; PCAP savefiles only, otherwise |
| | TCP over IPv6, and TCP tunnelled in IP (e.g. 6in4, 4in4), are |
| | left out of TCP reassembly and flow tracing, each with an |
| | :class:`~pcapkit.utilities.warnings.AttributeWarning` once |
| | per capture; IPv4 behind 802.1Q/802.1ad VLAN tags is read as |
| | it is untagged; PCAP savefiles only, otherwise |
| | :exc:`~pcapkit.utilities.exceptions.FormatError` |
+-----------------------------------------------------------------+---------------------------------------------------------------+
| :class:`~pcapkit.foundation.engines.dpkt.DPKT`, | no PCAP output, since each frame reaches the writer as a |
Expand Down
7 changes: 7 additions & 0 deletions docs/source/pcapkit/toolkit/3rdparty.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,13 @@ cannot be used for it.
:data:`None` -- which would be indistinguishable from "this frame carries no
IPv6 fragment".

Nor does it decode a VLAN tag or a tunnel. The adapters read an IPv4 packet
behind 802.1Q and 802.1ad tags as `PyPCAPFile`_ reads an untagged one, while
TCP over IPv6 and TCP tunnelled in IP (e.g. 6in4, 4in4, 6in6) are left out of
:func:`~pcapkit.toolkit.pypcapfile.tcp_reassembly` and
:func:`~pcapkit.toolkit.pypcapfile.tcp_traceflow`, with an
:class:`~pcapkit.utilities.warnings.AttributeWarning` once per capture for each.

.. autofunction:: pcapkit.toolkit.pypcapfile.ipv4_reassembly

.. autofunction:: pcapkit.toolkit.pypcapfile.ipv6_reassembly
Expand Down
Loading
Loading