Repository navigation
refactor(corekit): move the stream proxy classes into corekit.io (#1516) - #1521
Conversation
|
Coverage: 90.08% (unit tier, Python 3.14,
Per-file detail: the |
|
Verdict: GOOD TO GO at
Your call, not blocking: Pre-existing defect, to be filed separately: |
bf6796e to
5aff8a5
Compare
5aff8a5 to
b1ab653
Compare
- `_PeekableStream` (foundation/extraction.py) and `_NamedStream` (foundation/engines/pypcapfile.py) move to `pcapkit.corekit.io` as the public `PeekableStream` and `NamedStream`, beside `SeekableReader`, and join its `__all__`. Bodies are unchanged; both importers now take them from there. - Document both on the corekit io page. - tests/corekit/test_io_stream_proxies_1516_unit.py pins peek semantics, attribute forwarding, `.name` and read forwarding from the new module; the `_NamedStream` test in test_pypcapfile_engine.py moves there.
|
Verdict carried to |
b1ab653 to
0f6dce8
Compare
Please follow the guide below
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
refactor— changes neither behaviour nor performanceDescription of your pull request and other information
_PeekableStream(foundation/extraction.py) and_NamedStream(foundation/engines/pypcapfile.py) move topcapkit.corekit.ioas the publicPeekableStreamandNamedStream, besideSeekableReader, and join its__all__. Class bodies are unchanged; only the names and one cross-reference differ. Both importers take them fromcorekit.io, and the io docs page documents them.tests/corekit/test_io_stream_proxies_1516_unit.pypins peek semantics, attribute forwarding,.nameand read forwarding from the new module. Against6af87f608: 15 failed (ImportError /__all__); now 15 passed. The old_NamedStreamtest intest_pypcapfile_engine.pymoves there.tests/corekit,tests/foundation/test_extraction*.py,tests/project,tests/test_docstring_contract.py,tests/test_tier_guard.py; all pass.Closes #1516