Repository navigation
docs(reassembly): a fragment after its datagram completes starts a new buffer (#1507) - #1510
Merged
Merged
Conversation
JarryShaw
force-pushed
the
docs/1507-ip-reassembly-late-fragment
branch
from
October 9, 2026 21:00
1878504 to
6cf5547
Compare
Owner
Author
|
Verdict: GOOD TO GO at
|
JarryShaw
force-pushed
the
docs/1507-ip-reassembly-late-fragment
branch
from
October 9, 2026 21:24
6cf5547 to
3d2b060
Compare
Owner
Author
|
Verdict carried to |
Contributor
|
Coverage: 89.65% (unit tier, Python 3.14,
Per-file detail: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeAdded a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible — N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseDescription of your pull request and other information
Documents the ruling on #1507 item 1: a fragment that arrives after its datagram completed opens a new buffer, which surfaces as a separate incomplete datagram (RFC 791 §3.2, RFC 8200 §4.5, Linux, Zeek, Wireshark).
IP.reassemblydocstring gains aNote:;docs/source/pcapkit/foundation/reassembly/ip/index.rstgains one matching sentence. No code change.[('PARTIAL', (3,), (b'BBBB',)), ('COMPLETE', (1, 2), b'AAAAAAAABBBB')].make test:tests/test_docstring_contract.py7 passed;tests/foundation/reassembly101 passed;tests/project419 passed, 1 skipped.Refs #1507