Repository navigation
docs(sctp): a parsed Host Name may lack its null terminator - #1486
Merged
Merged
Conversation
#1483 made a captured Host Name without a NUL rebuild as captured, but the schema field comment still said the name always includes one, and the data comment read as a contradiction. Both now say the name is as captured.
JarryShaw
added
docs
Owner
Author
|
Verdict: GOOD TO GO at
|
JarryShaw
added
review: good-to-go
Contributor
|
Coverage: 89.57% (unit tier, Python 3.14,
Per-file detail: the |
JarryShaw
removed
the
review: good-to-go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make testpasses — comment-only;tests/test_docstring_contract.pypasses (7 passed)What is the purpose of your pull request?
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseDescription of your pull request and other information
Follow-up to #1482 and #1483, which made a captured Host Name without a null terminator rebuild as captured. Two comments still described the old rule:
pcapkit/protocols/schema/transport/sctp.py:596said the name always includes at least one null terminator. It now says the name is as captured: RFC 9260 asks for the terminator, but a parsed name may lack it.pcapkit/protocols/data/transport/sctp.py:363said "null terminator included; a parsed name may lack one", which contradicts itself. It now says "with any null terminator".Comments only; no behaviour change. #1483's cross-review flagged both lines.