Repository navigation
docs(engines): the dpkt engine silently drops PCAP-NG Simple Packet Blocks - #1370
Merged
Merged
Conversation
…locks dpkt.pcapng.Reader yields only Enhanced and (obsolete) Packet Blocks and skips every other block, Simple Packet Blocks included. Document that limit in the DPKT section of 3rdparty.rst and in the DPKT class docstring. Closes #1361
Owner
Author
|
Cross-review verdict on
A related limitation, which this PR rightly leaves alone and I am filing separately: |
Contributor
|
Coverage: 88.97% (unit tier, Python 3.14,
Per-file detail: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort) — not run; docs and a docstring onlymake testpasses, and a test case covers the change —tests/projectonly (389 passed, 1 skipped); docs-only, so no new testdocs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible — N/A, added centrallyWhat is the purpose of your pull request?
docs— documentation onlyDescription of your pull request and other information
Closes #1361
dpkt.pcapng.Reader.__iter__(dpkt 1.9.8,dpkt/pcapng.py:685-703) yields only EPB (:694) and PB (:698) blocks; everything else falls through to# just ignore other blocks(:703), the Simple Packet Block included. Measured onexamples/captures/test.pcapng(4 EPB + 1 SPB, 2 sections):default5 frames,scapy5,dpkt4.docs/source/pcapkit/foundation/engines/3rdparty.rst: animportantbox in DPKT Support stating the limit and the measurement.pcapkit/foundation/engines/dpkt.py: a matching paragraph in theDPKTclass docstring. The diff there is docstring-only (lines ~40-50), clear of fix(toolkit): dpkt reassembly adapters build their data from dpkt's re-serialised bytes and mutate the packet #1335's hunks at:150and:167.The new rst block and the napoleon-rendered docstring both parse under docutils with
halt_level=2; a full Sphinx build was not run.