Skip to content

fix(toolkit): dpkt reassembly adapters build their data from dpkt's re-serialised bytes and mutate the packet #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JarryShaw merged 1 commit into from
Oct 7, 2026
Merged

fix(toolkit): dpkt reassembly adapters build their data from dpkt's re-serialised bytes and mutate the packet #1335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pcapkit/foundation/engines/dpkt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,9 @@ def read_frame(self) -> 'DPKTPacket':
for more operational information.

"""
from pcapkit.toolkit.dpkt import (attach_timestamp, ipv4_reassembly, ipv6_reassembly,
packet2dict, tcp_reassembly, tcp_traceflow)
from pcapkit.toolkit.dpkt import (attach_buffer, attach_timestamp, ipv4_reassembly,
ipv6_reassembly, packet2dict, tcp_reassembly,
tcp_traceflow)
ext = self._extractor

reader = self._extmp
Expand All @@ -167,6 +168,10 @@ def read_frame(self) -> 'DPKTPacket':
# captured -- and anything reading a *stored* frame after this loop has
# moved on could not find out. Keep the two together from the start.
attach_timestamp(packet, timestamp)
# Nor does the packet keep the octets it was parsed from, and serialising
# it again recomputes zeroed checksums and lengths into it, so keep those
# too for the adapters to slice the wire octets out of.
attach_buffer(packet, pkt)

# verbose output
ext._frnum += 1
Expand Down
Loading
Loading