Repository navigation
chore(deps): add PyYAML to the test extra (#1076) - #1078
Merged
Merged
Conversation
The yaml.safe_load cross-checks in tests/project skipped on every CI leg, since each unit-tests.yml job installs .[test] and PyYAML was in no extra. Test-only: pcapkit never imports yaml. Rewrites the docstrings and skip messages that said PyYAML is in no extra, prose only.
2 of 5 tasks
JarryShaw
force-pushed
the
chore/1076-pyyaml-test-extra
branch
from
October 6, 2026 16:03
9674db8 to
14c30ed
Compare
Owner
Author
|
Cross-review verdict on
|
Contributor
|
Coverage: 88.74% (unit tier, Python 3.14,
Per-file detail: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
chore— anything elseDescription
Adds unpinned
PyYAMLto thetestextra only (not runtime;pcapkitnever importsyaml), so theyaml.safe_loadcross-checks run on every CI leg that installs.[test]. Also rewrites the docstrings and skip messages in fourtests/projectmodules that said PyYAML is in no extra. These are prose-only changes: with strings stripped, the AST matchesmain.Measured in a fresh 3.14 venv, without vs with PyYAML, skips per module:
test_project_status4 → 0,test_release_gates3 → 0,test_bump_version1 → 0.tests/test_tier_guard.py: 109 passed.tests/project: 375 passed, 1 skipped (#930, unrelated). Lint and the full suite were not run.test_project_status.py:231carries the same stale claim; it is left to #1077.Closes #1076