Repository navigation
docs(tests): tighten the shared test-support prose from the post-sweep merges (#719) - #1074
Merged
Merged
Conversation
JarryShaw
force-pushed
the
docs/719-final-tests-support
branch
from
October 6, 2026 13:41
7ea2079 to
7ec132a
Compare
JarryShaw
force-pushed
the
docs/719-final-tests-support
branch
from
October 6, 2026 13:43
7ec132a to
f9ca0e6
Compare
Contributor
|
Coverage: 88.74% (unit tier, Python 3.14,
Per-file detail: the |
Owner
Author
|
Cross-review verdict on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort) — not run; prose-only, AST-identicalmake testpasses, and a test case covers the changeAdded a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible — N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingchore— anything elseDescription of your pull request and other information
Final #719 pass over the prose
ef0964c81..mainadded totests/outsideprotocols/,foundation/,corekit/,project/. Comments and docstrings only.reimport_once_per_class: the unittest "import left in place" claim now excludesrestore=True, which restores the region at class end; timed wording cut.time_limit/conftest.pytest_timeout_cancel_timer: CI-history sentences cut; the measurements that justify them stay.test_compat: "purged and restored around every test" and "registered before anything else" were stale after the per-class switch.test_const_enum_lookup: two classes purge insetUpClass, notsetUp._DUNDER_SAMPLE_SIZEis a stride divisor (~50 members of TCP/UDP, all of SCTP/DCCP), not a stride.EndToEndTestCase.setUpClass: the claim thatrestore_module_tablesnapshots right after it was false. Under pytest the fixture restores the warm session pin before every test, so the purge and re-import never reach the tests (measured byid(sys.modules['pcapkit'])); the once-per-class rationale is now scoped to plain unittest._pin_module_snapshot's opening now states the current contract, andpytest_sessionstartno longer claims the reload saves ~45s or that a reimporting class keeps its import._helpers,builtin_parity,no_mint,registry_protocol.Numstat: 9 files, +81/-96. Tests: each touched module, every
EndToEndTestCasemodule, in its own pytest process, plustests/project(375 passed, 1 skipped).origin/main)