Repository navigation
docs(tests): tighten the protocols test prose from the post-sweep merges (#719) - #1073
Merged
Merged
Conversation
…ges (#719) - abc-cache setUp: name what now resets the cache and why the classes are still fresh per test (tearDown purges before the class import is kept) - dispatch reachability: drop the "no longer one import per test" history - option round trip / dispatch registry: the purge is in setUpClass; neither class has a setUp - ipv6_ext, pcapng: tighten the #917 cross-reference and the sweep-cache note Comments and docstrings only; AST-identical to origin/main.
Contributor
|
Coverage: 88.74% (unit tier, Python 3.14,
Per-file detail: the |
Owner
Author
|
Cross-review verdict on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort) — not run; comments/docstrings onlymake testpasses, and a test case covers the change — each touched module run alone, plustests/projectWhat is the purpose of your pull request?
docs— documentation onlyDescription
Final #719 pass over
tests/protocols/**prose touched byef0964c81..efc9c3774. Most of those 50 files only swappedpurge_modulesforreimport_once_per_class, with no prose. Changes:test_schema_metaclass_abc_cache_unit.py: the setUp comment creditedpurge_modules, which setUp no longer calls. It now namesreimport_once_per_classfor the cache reset, and says classes stay fresh per test only becausetearDownpurges before the class import is kept. Verified: theschemamodule id differs in every test.test_dispatch_reachability_unit.py: drop the "no longer one import per test" history.test_option_roundtrip_unit.py,test_dispatch_registry_unit.py: the comment cited asetUppurge, but neither class has asetUp; the purge is insetUpClass.test_ipv6_ext_unit.py,test_pcapng_unit.py: tightened wording.Tests: 6 modules pass;
tests/project375 passed, 1 skipped.tests/protocols/internet/test_ipv6_ext_unit.pytests/protocols/misc/test_pcapng_unit.pytests/protocols/schema/test_schema_metaclass_abc_cache_unit.pytests/protocols/test_dispatch_reachability_unit.pytests/protocols/test_dispatch_registry_unit.pytests/protocols/test_option_roundtrip_unit.py