Repository navigation
docs(tests): tighten the foundation and corekit test prose from the post-sweep merges (#719) - #1072
Merged
Merged
Conversation
…ost-sweep merges (#719)
Owner
Author
|
Cross-review verdict on
|
Contributor
|
Coverage: 88.74% (unit tier, Python 3.14,
Per-file detail: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort) — not run; comment-only change, AST guard belowmake testpasses, and a test case covers the change — the four touched modules andtests/project, one process eachAdded a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible — N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
docs— documentation onlyDescription of your pull request and other information
Final #719 pass over
tests/foundation/**andtests/corekit/**prose added by the commits sinceef0964c81. Comments only.test_extraction.pyandtest_fields_collections.py, keeping the reason (the class shares one import).test_fields_field.py: the ledger comment blamed "a sibling class, another module"; each class purges first, so itsfieldmodule (and_zero_pad_ledger) is its own. The leak is from earlier tests of the same class.test_foundation.py:setUpdoes not swap in a fresh import for every test, it puts the class's own one back.tests/corekit/test_fields_collections.pytests/corekit/test_fields_field.pytests/foundation/registry/test_foundation.pytests/foundation/test_extraction.py