You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
vendor(apptype): duplicated _missing_ range guards mint members with the wrong transport #760
A member minted into the UDP registry for a UDP lookup should carry udp in .proto. Either the duplicate guards are merged with a combined transport, or the reachable one is chosen by the caller's transport rather than by source order.
System information
OS Version: Linux 5.10 (Amazon Linux 2 int)
Python Version: 3.14.7
Python Implementation: CPython
pcapkit Version: checkout at 932cb48d1
Additional context
Found while verifying #736 after #754. This is #736's "related, same area" note, now half fixed: the second call no longer raises TypeError — the minted member is in the owner's registry, so is holds — but the wrong .proto survives.
apptype.py is generated, so the fix belongs in the crawler (pcapkit/vendor/reg/apptype/), not in the emitted file. Note this interacts with #732's deferred TransportProtocol retype: if only declared values are accepted, a merged guard needs a named combination rather than an OR.
Activity
perf(reg): drop the per-member annotation and TransportProtocol.get()…
perf(reg): drop the per-member annotation and TransportProtocol.get()…