Skip to content

fix(internet): MH options 6 and 27 raise a bare ValueError on values their data models cannot hold #2702

Closed

Description

@JarryShaw

Found while reviewing #2700 and confirmed by a Sonnet cross-review. Identical on main. Two MH mobility options raise a plain ValueError, not a pcapkit BaseError, when parsed on their own:

  • Option 6 (MNP): a prefix with host bits set raises "has host bits set", from IPv6Network.
  • Option 27 (Timestamp): a time past year 9999 raises "year is out of range", from datetime.

Inside IPv6 both stay Raw and rebuild exactly. Standalone they should raise ProtocolError, or keep the value in a form the data model can hold, so that the round trip still matches.

Activity

  1. added this to the PyPCAPKit v1.6 milestone on Nov 2, 2026
  2. added
    bugIssues reporting a defect (set by the bug report template; a default, not an assessment)
    on Nov 2, 2026
  3. moved this to Pending in PyPCAPKiton Nov 2, 2026
  4. JarryShaw commented on Nov 3, 2026

    @JarryShaw
    OwnerAuthor

    A worker is on it now. Moved to wip.

  5. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Nov 3, 2026
  6. moved this from Pending to WIP in PyPCAPKiton Nov 3, 2026
  7. JarryShaw commented on Nov 3, 2026

    @JarryShaw
    OwnerAuthor

    The PR is #2709. A Sonnet review is running.

  8. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIssues reporting a defect (set by the bug report template; a default, not an assessment)

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions