Repository navigation
docs(toolkit): _default_extension_header keeps a header captured short, contrary to its docstring #2695
Description
Found while re-reviewing #2683; identical on main. The toolkit's _default_extension_header(135, bytes.fromhex('11020742d5bd297b')) returns (17, 24) for an 8-octet capture. Its docstring says it answers None when fewer octets were captured than the header needs, and _walk_extension_headers then slices data[24:] to b''. Make the docstring and the code agree. #2526 relies on the header being kept, so the docstring is the likely side to change.
Activity
JarryShaw commentedon Nov 2, 2026
The host load has cleared, so a worker is on it now. Moved to
wip.docs(toolkit): say the IPv4 extension-header reader keeps a header cu…
JarryShaw commentedon Nov 2, 2026
Fixed on
mainatbe8306140. This is a docs-and-test-only push: the syntax tree with docstrings stripped is identical tomain._default_extension_headernow documents its real contract: it answersNonebelow the parser's__length_hint__, and from there keeps the header at its declared length, as IPv4 dissection does._walk_extension_headers' docstring is corrected the same way.docs(changelog): fold the MH option refusals, radiotap's mixed bitmap…